Relax version requirements to accept a greater version#130
Conversation
|
This can make the install fail if one of these modules update and change apis/has bugs (not very likely to happen but you never know (cf things like jashkenas/underscore#1805) and ensure that 2 installs of mkdocs 1.0 (for example) will be identical. I usually just update all the dependencies once in a while but if other people prefer that way then it's fine |
|
I'm not sure about this - holding off for the moment. |
004c2ae to
98836e2
Compare
|
@tomchristie Could you check this over? I think it is okay, but I'm not 100% sure. Both myself and @sampsyo (see #104) have ran into version issues. |
|
Should this increase the minimum versions? I wasn't sure, so I just opted to go for greater than or equal to what we required before. The specific issue I ran into was something else installed Jinja2 2.7.3 (as a requirement) but MkDocs requires exactly 2.7.1. |
98836e2 to
26e63fb
Compare
|
huh, interesting. It looks like the latest python-markdown (2.4.x) has dropped Python 2.6 support (hence the failure on Travis). That might just settle the question of how long we support 2.6. |
|
For anyone else curious, this is when/why they dropped 2.6: Python-Markdown/markdown@44e718e#diff-2eeaed663bd0d25b7e608891384b7298 |
There was a problem hiding this comment.
Perhaps this is supposed to match the constraint in setup.py, below?
Also, it seems to me (could be wrong) that Python 2.6 support was dropped in Markdown 2.5, not 2.4. (In case that's the reason you're requiring <2.4.)
|
Looks great to me (modulo the above comment)! |
26e63fb to
27b3268
Compare
|
Good spot - after the Python 2.6 error I tried to update it too quickly. |
|
In light of finding this out about python-markdown, I opened #165 |
|
This is how I generally do it, and IMO is a reasonable best practice |
|
I strongly agree for
|
|
@mjtamlyn I'd be concerned about the unittests being pinned, as I want them to fail if a new version is an issue. I think I'll go with this for now, it's got to be better than the current situation which breaks things :) Thanks all! |
Relax version requirements to accept a greater version
|
Awesome! Major props! ✨ |
5 participants
The requirements are currently pinned - this is an issue as it requires very specific versions. This change updates it to be more flexible and allow anything greater than our previous minimum.
Fixes #104