Fix SonarCloud reliability and security hotspot issues - #113
Conversation
* Adds a null check for `uploadStorageService` in `RufhAppendValidator.java` to prevent a potential `NullPointerException` identified by SonarCloud as a Reliability issue. * Pins the `coverallsapp/github-action` dependency in `.github/workflows/build.yml` to the specific commit SHA `8d6379e14d29928660c4ba802d8e85393440b329` (v2.3.8) to resolve a Security Hotspot. * Adds a unit test `testValidateStorageServiceNull` in `RufhAppendValidatorTest.java` to ensure the new null check works correctly and maintains code coverage. Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
coverage: 96.487% (-0.02%) from 96.506% — bugfix/fix-sonar-issues-2851799642143350705 into master |
2 participants
This branch resolves SonarCloud issues reported for the
tus-java-serverproject.Reliability fix:
Added a check to exit early in
RufhAppendValidator.validateifuploadStorageServiceis null, resolving a potential NullPointerException highlighted by SonarCloud. Added a corresponding unit test to maintain 100% test coverage.Security hotspot fix:
Pinned the
coverallsapp/github-actionGitHub Action to its exact commit SHA (v2.3.8) in.github/workflows/build.ymlinstead of the genericv2tag, improving the supply-chain security posture.PR created automatically by Jules for task 2851799642143350705 started by @tomdesair