Skip to content

🧪 [testing improvement] Add tests for TusServletRequest trailer header fallback - #129

Merged
tomdesair merged 1 commit into
masterfrom
feature/add-tus-servlet-request-test-8727877931933897901
Aug 30, 2026
Merged

🧪 [testing improvement] Add tests for TusServletRequest trailer header fallback#129
tomdesair merged 1 commit into
masterfrom
feature/add-tus-servlet-request-test-8727877931933897901

Conversation

@tomdesair

Copy link
Copy Markdown
Owner

🎯 What: The TusServletRequest was missing test coverage for the getHeader(String name) fallback logic. Specifically, when super.getHeader(name) returns a blank value or null, the class is supposed to look up the value in trailerHeaders.
📊 Coverage: Added test cases in TusServletRequestTest to cover standard header retrieval, fallback to trailerHeaders when the header is missing, fallback to trailerHeaders when the header is blank, and when a header does not exist in standard or trailer headers.
Result: The test coverage for TusServletRequest.java has been improved, and the previously untested method is fully covered.


PR created automatically by Jules for task 8727877931933897901 started by @tomdesair

…r fallback

Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 94.595%feature/add-tus-servlet-request-test-8727877931933897901 into master. No base build found for master.

@tomdesair
tomdesair merged commit c641981 into master Aug 30, 2026
9 checks passed
@tomdesair
tomdesair deleted the feature/add-tus-servlet-request-test-8727877931933897901 branch August 30, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants