Fix vertical misalignment of :: after angle brackets#1685
Open
crespinl wants to merge 1 commit intotonsky:masterfrom
Open
Fix vertical misalignment of :: after angle brackets#1685crespinl wants to merge 1 commit intotonsky:masterfrom
:: after angle brackets#1685crespinl wants to merge 1 commit intotonsky:masterfrom
Conversation
Fixes a bug where `::` would render misaligned in sequences like `toto<int>::Function()`, with the first colon on the baseline and the second shifted up.
Contributor
|
Perhaps fixes #1346. Potentially affects #1061 and/or #980. Current-ish glyphsThese are the same glyphs as 6.902HH but scaled down to 1000 units per em (because I'm in over my head). Regular weight. 36 pt.
PR 1685 glyphsThese are the glyphs from the PR, also scaled down to 1000.
Images with a difference layer
Text in the imagesI copied and pasted text from Issues and one commit to make the following. I saw that you had tagged one of the issues as case-sensitive, so I added the lower-case "function". thank youDude, my escapades into font files have convinced me that I never want to design a font. So, thank you very, very much for gifting us the benefits of your knowledge and hard work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



First of all, I'm a complete beginner when it comes to fonts, so I hope I did nothing bad.
The issue was caused by a rule that prevented
::and:::from ligating when adjacent to<or>. Because the colons were kept separate, the second colon was independantly shifted upwards to align with the following uppercase letter, while leaving the first colon on the baseline.By removing the
ignore subrules for colons next to angle brackets,::now properly forms a singlecolon_colon.ligaunit.This fixes #1684, #1329 and #1225