feat: add pagination to GET /tasks - #18
Open
tonysong8 wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Looks good overall! One thought — should we cap the max cputime unlimited |
Owner
Author
|
reviewed - prioritizing with team |
Owner
Author
|
Agreed on the cap — suggest defaulting max limit to 100 |
1 similar comment
Owner
Author
|
Agreed on the cap — suggest defaulting max limit to 100 |
Owner
Author
|
테스트 플랜 항목들에 대해 좀 더 상세한 설명을 부탁드립니다. 각 항목별로 예상 입력값, 예상 결과, 그리고 테스트 방법을 구체적으로 작성해 주시면 검토에 도움이 될 것 같습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2
Adds a
paginate()utility and wires it intoGET /tasksso the endpoint no longer returns unbounded results.Changes
src/pagination.jsutility withpageandlimitsupport{ data, total, page, limit }Test Plan
GET /tasks?page=1&limit=5returns first 5 tasksGET /tasks?page=2&limit=5returns next 5