Potential fix for code scanning alert no. 1: Information exposure through an exception - #9
Merged
Merged
Conversation
…ough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/tonytech83/Inventory/security/code-scanning/1
To fix this safely, keep the bulk-import behavior and per-row success/failure reporting, but stop returning raw exception details to the client.
Best approach (without changing functional behavior):
inventory/devices/utils.py, add server-side logging.except Exception as e:block, log the exception with context (e.g., device name/row info) usinglogger.exception(...)."error": str(e)inresultswith a generic message like"Device could not be imported due to invalid data.".This preserves:
status: Errorstill present),resultsstill includes anerrorfield).Files/regions to change:
inventory/devices/utils.py: importlogging, define module logger, and update exception handling block increate_devices_form_upload.Suggested fixes powered by Copilot Autofix. Review carefully before merging.