This repository was archived by the owner on Mar 8, 2026. It is now read-only.
Respect goversion build directives.#449
Closed
CannibalVox wants to merge 1 commit intotools:masterfrom
Closed
Conversation
Yesterday afternoon, context rolled out a pre-1.7 update that uses build directives to control whether the 1.6 or 1.7 files are compiled. These are in the format +build go1.7 and +build !go1.7. Godep does not currently respect these build directives and chokes trying to vendor context. This should repair this behavior, allowing us to use context again.
Author
|
Related to #448 |
| if p.Goroot { | ||
| return nil | ||
| } | ||
| version, err := goVersion() |
There was a problem hiding this comment.
I think this should use the recorded go version from the Godeps.json file, not whichever go version is currently running.
Closed
|
Closing in favor of #451 for now. Thanks for taking the time to take a stab at this though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday afternoon, context rolled out a pre-1.7 update that uses build directives to control whether the 1.6 or 1.7 files are compiled. These are in the format +build go1.7 and +build !go1.7. Godep does not currently respect these build directives and chokes trying to vendor context. This should repair this behavior, allowing us to use context again.