This repository was archived by the owner on Mar 8, 2026. It is now read-only.
Conversation
Fixes #448 Obey the go tool's definition of how the go versions build tags work for the purposes of dependency scanning. Don't use the current go version, but the recorded go version in Godeps.json. FIXME: We still copy the files. This is sub optimal, but probably fine in the 80% case where people are using the version of go they have specified in the Godeps.json file. Longer term we need to obey the gofiles / ignore lists from the package list.
This was referenced Apr 6, 2016
|
This fixes issue #448 for me. |
Author
|
Merged as 35ee059 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #448
Obey the go tool's definition of how the go versions build tags work for
the purposes of dependency scanning.
Don't use the current go version, but the recorded go version in
Godeps.json.
FIXME: We still copy the files. This is sub optimal, but probably fine
in the 80% case where people are using the version of go they have
specified in the Godeps.json file. Longer term we need to obey the
gofiles / ignore lists from the package list.
IMO, Supersedes #449