[code-review] subagent notifyUpdate throttle updates lastNotify before check — permanently suppresses UI updates during streaming

[topcheer]

notifyUpdate throttle updates lastNotify on every call — permanently suppresses UI updates during streaming

Severity: Medium

File and Lines

internal/subagent/manager.go, lines ~1085-1100

Problem Description

The notifyUpdate method updates m.lastNotify = now before the throttle check, including on calls that get skipped:

now := time.Now()
lastNotify := m.lastNotify
m.lastNotify = now          // ← updated unconditionally
...
if !lastNotify.IsZero() && now.Sub(lastNotify) < 100*time.Millisecond {
    return                   // ← skipped, but lastNotify already advanced
}
fn(sa)

When events arrive at <100ms intervals (normal during streaming — 30-100 tokens/s), lastNotify is always recent enough that now.Sub(lastNotify) is always <100ms. After the first delivery, fn(sa) is never called again as long as events keep arriving.

Trigger Scenario

Any sub-agent streaming output (LLM tokens arriving every 10-50ms). The onUpdate callback fires once, then never again until the event stream pauses for >100ms.

Expected vs Actual

• Expected: ~10 Hz update rate (every 100ms) as documented
• Actual: 0 Hz during continuous streaming — UI shows stale status/phase

Impact

• onStreamText is a separate unthrottled channel, so text still streams
• But status/phase/activity updates (tool transitions, progress) are frozen during active streaming
• All callers affected: Cancel, Start, SetActivity, Notify, Complete

Fix Suggestion

Only update m.lastNotify when actually delivering:

if !lastNotify.IsZero() && time.Since(lastNotify) < 100*time.Millisecond {
    return  // do NOT update m.lastNotify
}
m.lastNotify = time.Now()
fn(sa)

[topcheer]

已修复 (commit 7746410)。

修复：m.lastNotify 现在仅在真正执行 fn(sa) 回调时才更新，不再在 throttled（跳过）的调用中提前推进水位线。这样在连续流式输出（事件间隔 <100ms）时，UI 状态/阶段更新不再被永久抑制，恢复为预期的 ~10Hz 更新频率。