issue #1519 - Screen flicker in dropdown #1521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed noScroll class
Contributor
|
The reason for adding the "noScroll" is to prevent double scrolling when the notifications dropdown is shown. Before that reaching at the end of the notifications on scroll would start scrolling the page under the menu. The jumping is caused by the showing/hiding of the browser scrollbar. I'll put the top bar above everything so the container would never need to have a scrollbar and thus the behavior would be fixed. This is a CSS problem to have, I'm on it. Let's hold with reversal of the code for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1519 - Screen flicker in dropdown
Removed noScroll class