Skip to content

issue #1519 - Screen flicker in dropdown #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vic-georgiev merged 1 commit into from
Dec 22, 2017
Merged

issue #1519 - Screen flicker in dropdown #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/components/NotificationsDropdown/NotificationsDropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
// this is to include tc styles in the output library
@import 'tc-includes';

// Prevent the page scrolling while scrolling into the notification dropdown
body.noScroll {
overflow: hidden;
}

// project override for dropdown shadow
.Dropdown {
box-shadow: 0 3px 30px 2px rgba(0, 0, 0, 0.5);
Expand Down
11 changes: 1 addition & 10 deletions src/components/NotificationsDropdown/NotificationsDropdownContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@ class NotificationsDropdownContainer extends React.Component {
this.props.getNotifications()
}

// Make sure the body isn't scrollable when mouse is over the drop-down menu
freezeBody(){
document.body.classList.add('noScroll')
}

unfreezeBody(){
document.body.classList.remove('noScroll')
}

render() {
if (!this.props.initialized) {
return null
Expand Down Expand Up @@ -66,7 +57,7 @@ class NotificationsDropdownContainer extends React.Component {
</NotificationsEmpty>
</div>
) : ([
<div key="body" className="notifications-dropdown-body" onMouseEnter={this.freezeBody} onMouseLeave={this.unfreezeBody} >
<div key="body" className="notifications-dropdown-body">
{globalSource && globalSource.notifications.length &&
<NotificationsSection
{...globalSource}
Expand Down