Github issue#2396, Refactor the way we are storing project template id while creating project #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d while creating project Refactored the usage of `details.products[0]` in project creation. We are still using this path to access the product id of the legacy (v2) projects while rendering legacy projects
maxceem
reviewed
Aug 22, 2018
| if (projectTemplate) { | ||
| // load project details page directly | ||
| if (project.key === incompleteProjectTemplateKey) { | ||
| if (projectTemplate.key === incompleteProjectTemplate.key) { |
Collaborator
There was a problem hiding this comment.
Just for consistency this line looks like can be replaced to use id: projectTemplate.id === incompleteProjectTemplate.id.
Author
There was a problem hiding this comment.
Good catch. However, I left that intentionally considering that in future we have to keep versions of templates i.e. we would try to eliminate the usage of templates by id as much as possible. In this specific case I am using key because this loads the project template based on the key in URL and in case we get new a template for the same key (through versioning), it would still got the project details page with the latest template of that key instead of asking the project template again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the usage of
details.products[0]in project creation. We are still using this path to access the product id of the legacy (v2) projects while rendering legacy projects.for #2396