Skip to content

fix Roboto font loading #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RishiRajSahu merged 1 commit into from
Oct 9, 2018
Merged

fix Roboto font loading #2589

RishiRajSahu merged 1 commit into from
Oct 9, 2018

Conversation

@maxceem
Copy link
Collaborator

@maxceem maxceem commented Oct 9, 2018

fix Roboto font loading #2588

  • Note: I've removed default font-size and line-height from body as for a long time we've been writing styles without these default styles, and putting them back breaks some styles

@maxceem maxceem requested a review from RishiRajSahu October 9, 2018 05:52
@maxceem maxceem mentioned this pull request Oct 9, 2018
Closed
@RishiRajSahu RishiRajSahu merged commit 9998e03 into dev Oct 9, 2018
@maxceem maxceem deleted the feature/fix-roboto-font branch October 24, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RishiRajSahu RishiRajSahu RishiRajSahu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxceem @RishiRajSahu