Skip to content

fixes issue 2903 #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxceem merged 2 commits into from
Apr 15, 2019
Merged

fixes issue 2903 #2941

maxceem merged 2 commits into from
Apr 15, 2019

Conversation

@sumitdaga
Copy link
Contributor

@sumitdaga sumitdaga commented Apr 11, 2019

No description provided.

@sumitdaga sumitdaga mentioned this pull request Apr 11, 2019
Closed
@maxceem maxceem self-requested a review April 15, 2019 04:18
maxceem
maxceem requested changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sumitdaga

There are couple cases which are not supported yet:

  1. Extra closing parenthesis causes that evaluate function never finishes: (someArrayWithText contains 'a') || (someArrayWithText contains 'b') || (someArrayWithText contains 'c'))

  2. Same, for multiple extra closing parenthesis: (someArrayWithText contains 'a') || (someArrayWithText contains 'b')) || (someArrayWithText contains 'c'))

  3. Please, don't include into commit describe.only.

  4. As we can only find the token index, not the text index. Update the error message to Parens with the following token indexes are unbalanced: ${unbalancedParens}

@sumitdaga
Copy link
Contributor Author

sumitdaga commented Apr 15, 2019

@maxceem
please take a look now !

maxceem
maxceem approved these changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good @sumitdaga.
Thank you.

@maxceem maxceem merged commit ff15262 into topcoder-archive:cf16 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxceem maxceem maxceem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sumitdaga @maxceem