-
Notifications
You must be signed in to change notification settings - Fork 136
Implement scope change request workflow #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement scope change request workflow #3193
Conversation
src/projects/detail/components/EditProjectForm/EditProjectForm.jsx
Outdated
Show resolved
Hide resolved
src/projects/detail/components/EditProjectForm/EditProjectForm.jsx
Outdated
Show resolved
Hide resolved
src/projects/detail/components/ScopeChangeRequest/ScopeChangeRequest.jsx
Show resolved
Hide resolved
src/projects/detail/components/ScopeChangeRequest/ScopeChangeRequest.jsx
Outdated
Show resolved
Hide resolved
|
Overall looks good with few suggestions. |
|
@vigneshTheDev Do you think you would be able to wrap the suggested changes today EOD? |
vigneshTheDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikasrohit, I've noted about this change #3193 (comment). I just updated it to use the updated service. I'll add the merge logic. I'm writing here because, for some reason, I'm not able to comment on the issue
src/projects/detail/components/ScopeChangeRequest/ScopeChangeRequest.jsx
Show resolved
Hide resolved
src/projects/detail/components/ScopeChangeRequest/ScopeChangeRequest.jsx
Show resolved
Hide resolved
src/projects/detail/components/ScopeChangeRequest/ScopeChangeRequest.jsx
Show resolved
Hide resolved
@vigneshTheDev I am not able to see the changes |
|
@vikasrohit Sorry about the confusion. I haven't added the logic for merging yet.
I was talking about using the updated scope from the service response instead of updating the status on the fly in the UI. |
Implements the task in the issue: #2970