Github issue#3202, Progress bar is showing wrong progress for Final fix milestone

[vikasrohit]

• Should fix it.

fyi @maxceem @RishiRajSahu

[maxceem]

The code of this PR looks good to me. Though I didn't manage to reproduce the original issue as per description #3202.

I followed the steps, but using Development Iteration (3 Milestones) phase on DEV see the project https://connect.topcoder-dev.com/projects/8218. Though after I set actualStartDate one day before I still can see 2 days remaining event without the fix:

Here is the data of this milestone:

{
    "id": "9dedfcc5-f638-40e1-b537-a0e10deb8858",
    "version": "v4",
    "result": {
        "success": true,
        "status": 200,
        "content": {
            "id": 23175,
            "name": "Delivery",
            "description": "Development has been completed! This marks the end of the milestone. Below you'll find the source files attached as a .zip archive, as per the phase specifications. They'll also be permanently available for download at your convenience.",
            "duration": 1,
            "startDate": "2019-07-24T00:00:00.000Z",
            "actualStartDate": "2019-07-21T00:00:00.000Z",
            "endDate": "2019-07-24T00:00:00.000Z",
            "completionDate": null,
            "status": "reviewed",
            "type": "delivery-dev",
            "details": {
                "metadata": {
                    "waitingForCustomer": false
                },
                "prevMilestoneType": "generic-work",
                "content": {
                    "isFinalFixesSubmitted": true
                }
            },
            "order": 6,
            "plannedText": "Once you accept the code, your source files will be delivered here.1",
            "activeText": "Once you accept the code, your source files will be delivered here.",
            "completedText": "Development has been completed! This marks the end of the milestone. Below you'll find the source files attached as a .zip archive, as per the phase specifications. They'll also be permanently available for download at your convenience.",
            "blockedText": "Once you accept the code, your source files will be delivered here.",
            "hidden": false,
            "createdAt": "2019-07-22T08:50:39.000Z",
            "updatedAt": "2019-07-22T09:01:19.000Z",
            "createdBy": 40152856,
            "updatedBy": 40152922,
            "timelineId": 4140,
            "statusHistory": [
                {
                    "id": 927,
                    "reference": "milestone",
                    "referenceId": 23175,
                    "status": "reviewed",
                    "comment": null,
                    "createdBy": 40152856,
                    "createdAt": "2019-07-22T09:01:18.000Z",
                    "updatedBy": 40152922,
                    "updatedAt": "2019-07-22T09:01:18.000Z"
                },
                {
                    "id": 926,
                    "reference": "milestone",
                    "referenceId": 23175,
                    "status": "active",
                    "comment": null,
                    "createdBy": 40152856,
                    "createdAt": "2019-07-22T08:52:03.000Z",
                    "updatedBy": 40152856,
                    "updatedAt": "2019-07-22T08:52:03.000Z"
                },
                {
                    "id": 915,
                    "reference": "milestone",
                    "referenceId": 23175,
                    "status": "reviewed",
                    "comment": null,
                    "createdBy": 40152856,
                    "createdAt": "2019-07-22T08:50:39.000Z",
                    "updatedBy": 40152856,
                    "updatedAt": "2019-07-22T08:50:39.000Z"
                }
            ]
        },
        "metadata": {
            "totalCount": 1
        }
    }
}

[vikasrohit]

I followed the steps, but using Development Iteration (3 Milestones) phase on DEV see the project https://connect.topcoder-dev.com/projects/8218.

It might be because I didn't followed those steps as well. 😬 I just wrote those steps to recreate the error just based on my theory.

Anyway finally you are able to reproduce it. Did the fix worked for you as well?

[maxceem]

Anyway finally you are able to reproduce it

Nope, I didn't manage to reproduce it. Do you have a place where you can observe this issue without your fix?

[vikasrohit]

Ohk. I don't have any data on dev, but yesterday one of the phase for our Connect project was not showing correct days left. It happened when I updated the milestone's actualStartDate after completing the milestones.