Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fix: issue #525 #527

Merged
merged 1 commit into from
Oct 26, 2021
Merged

fix: issue #525 #527

merged 1 commit into from
Oct 26, 2021

Conversation

@yoution
Copy link
Contributor

@yoution yoution commented Oct 25, 2021

@maxceem please review

@maxceem maxceem changed the base branch from feature/interview-update to dev October 25, 2021 14:52
@maxceem maxceem changed the base branch from dev to feature/interview-update October 25, 2021 14:53
maxceem
maxceem suggested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution it works good. But we need to get it done in dev branch.

feature/interview-update branch is only for Interview workflow.

@yoution yoution changed the base branch from feature/interview-update to dev October 26, 2021 02:18
@yoution yoution requested a review from maxceem October 26, 2021 02:18
maxceem
maxceem approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution works as per local testing, passing for QA.

@maxceem maxceem merged commit 9250c64 into topcoder-archive:dev Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@maxceem maxceem maxceem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoution @maxceem