Skip to content

fix(PM-2539): Added timeout to prisma service in member service #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

fix(PM-2539): Added timeout to prisma service in member service #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
675dde2
added timeout for prisma services
hentrymartin Oct 27, 2025
50fa3d6
Merge branch 'develop' into pm-2539
hentrymartin Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ workflows:
branches:
only:
- develop
- pm-2539

# Production builds are exectuted only on tagged commits to the
# master branch.
Expand Down
3 changes: 2 additions & 1 deletion config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,6 @@ module.exports = {

HASHING_KEYS: {
USERFLOW: process.env.USERFLOW_PRIVATE_KEY
}
},
MEMBER_SERVICE_PRISMA_TIMEOUT: process.env.MEMBER_SERVICE_PRISMA_TIMEOUT ? parseInt(process.env.MEMBER_SERVICE_PRISMA_TIMEOUT, 10) : 10000,
Copy link

@github-actions github-actions bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Consider adding validation to ensure process.env.MEMBER_SERVICE_PRISMA_TIMEOUT is a valid integer before parsing it with parseInt. This will prevent potential issues if the environment variable is set to a non-numeric value, which would result in NaN and default to 10000. You can use Number.isInteger() or similar checks for validation.

}
4 changes: 4 additions & 0 deletions src/common/prisma.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ const {
Prisma
} = require('../../prisma/generated/client')
const { PrismaClient: SkillsPrismaClient } = require('../../prisma/generated/skills-client')
const config = require('config')

const clientOptions = {
transactionOptions: {
timeout: config.MEMBER_SERVICE_PRISMA_TIMEOUT,
Copy link

@github-actions github-actions bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Ensure that config.MEMBER_SERVICE_PRISMA_TIMEOUT is properly validated and has a sensible default value. If this value is undefined or set to an inappropriate value, it could lead to unexpected behavior in the transaction timeout.

},
log: [
{ level: 'query', emit: 'event' },
{ level: 'info', emit: 'event' },
Expand Down