Conversation
What was broken The previous PM-4840 fix restored persisted copilot and reviewer assignments during refresh hydration, but saving an existing draft could still reset the editor from a sparse challenge payload that omitted resource-backed reviewer members. That left refreshed or reopened drafts showing blank reviewer assignments again even though the resources were already saved. Root cause (if identifiable) The post-save reset path rebuilt form state from the `patchChallenge` response and only reapplied single-member assignments from the in-memory hook state. When the hook cache did not already contain the saved reviewer resources, manual reviewer members were dropped from the form state until a later fetch happened. What was changed The draft save flow now reloads persisted resources and resource roles before resetting the form, then reapplies the shared copilot and manual-reviewer hydration logic to the saved draft state. This keeps saved reviewer assignments attached immediately after save and when the draft is reopened. Any added/updated tests Added ChallengeEditorForm coverage for saving a draft when the hook resource cache is empty but persisted reviewer assignments exist in freshly fetched resources.
PM-4840: rehydrate persisted reviewer assignments after draft saves
Bumps [axios](https://github.com/axios/axios) from 1.13.2 to 1.15.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.13.2...v1.15.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.15.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [handlebars](https://github.com/handlebars-lang/handlebars.js) from 4.7.8 to 4.7.9. - [Release notes](https://github.com/handlebars-lang/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.9/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.8...v4.7.9) --- updated-dependencies: - dependency-name: handlebars dependency-version: 4.7.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.5.3 to 4.5.6. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v4.5.3...v4.5.6) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 4.5.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/axios-1.15.0 Bumps [axios](https://github.com/axios/axios) from 1.13.2 to 1.15.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.13.2...v1.15.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.15.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rn/handlebars-4.7.9 Bump handlebars from 4.7.8 to 4.7.9
…rn/fast-xml-parser-4.5.6 Bump fast-xml-parser from 4.5.3 to 4.5.6
Bumps [rollup](https://github.com/rollup/rollup) from 2.79.2 to 2.80.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/v2.80.0/CHANGELOG.md) - [Commits](rollup/rollup@v2.79.2...v2.80.0) --- updated-dependencies: - dependency-name: rollup dependency-version: 2.80.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.3 to 3.4.2. - [Commits](WebReflection/flatted@v3.3.3...v3.4.2) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/rollup-2.80.0 Bump rollup from 2.79.2 to 2.80.0
…rn/flatted-3.4.2 Bump flatted from 3.3.3 to 3.4.2
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.18.1. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.18.1) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.18.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/lodash-4.18.1 Bump lodash from 4.17.21 to 4.18.1
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.3 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.3...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/node-forge-1.4.0 Bump node-forge from 1.3.3 to 1.4.0
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core) from 7.6.20 to 7.6.21. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.v1-5.md) - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.21/code/core) --- updated-dependencies: - dependency-name: storybook dependency-version: 7.6.21 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [defu](https://github.com/unjs/defu) from 6.1.4 to 6.1.7. - [Release notes](https://github.com/unjs/defu/releases) - [Changelog](https://github.com/unjs/defu/blob/main/CHANGELOG.md) - [Commits](unjs/defu@v6.1.4...v6.1.7) --- updated-dependencies: - dependency-name: defu dependency-version: 6.1.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.21 to 4.18.1. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.18.1) --- updated-dependencies: - dependency-name: lodash-es dependency-version: 4.18.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jsonpath](https://github.com/dchester/jsonpath) from 1.1.1 to 1.3.0. - [Commits](https://github.com/dchester/jsonpath/commits) --- updated-dependencies: - dependency-name: jsonpath dependency-version: 1.3.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/storybook-7.6.21 Bump storybook from 7.6.20 to 7.6.21
…rn/defu-6.1.7 Bump defu from 6.1.4 to 6.1.7
…rn/lodash-es-4.18.1 Bump lodash-es from 4.17.21 to 4.18.1
…rn/jsonpath-1.3.0 Bump jsonpath from 1.1.1 to 1.3.0
…ls-load PM-4878 load appeals in bulk
…n-disabled-workflow PM-4879 - prevent challenge save when workflow is disabled
…n-disabled-workflow PM-4879 - prevent saving with wrong template
PM-4804 - for f2f challenges when completed show the winners tab
PM-4886 Update default state of talent search
PM-4886 Fix filters on talent search
PM-4886 Use backend sorting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+18723
to
+18726
| underscore@1.13.6: | ||
| version "1.13.6" | ||
| resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.13.6.tgz#04786a1f589dc6c09f761fc5f45b89e935136441" | ||
| integrity sha512-+A5Sja4HP1M08MaXya7p5LvjuM7K6q/2EaC0+iovj/wOcMsTzMvDFbasi/oSapiwOlt252IqsKqPjCl7huKS0A== |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-4777
https://topcoder.atlassian.net/browse/PM-4918
https://topcoder.atlassian.net/browse/PM-4917
https://topcoder.atlassian.net/browse/PM-4878
https://topcoder.atlassian.net/browse/PM-4834
https://topcoder.atlassian.net/browse/PM-4879
https://topcoder.atlassian.net/browse/PM-4895
https://topcoder.atlassian.net/browse/PM-4890
https://topcoder.atlassian.net/browse/PM-4859
https://topcoder.atlassian.net/browse/PM-4886
https://topcoder.atlassian.net/browse/PM-4882
https://topcoder.atlassian.net/browse/PM-4903
https://topcoder.atlassian.net/browse/PM-4893
https://topcoder.atlassian.net/browse/PM-4900