Conversation
What was broken Completed, offer rejected, and terminated assignment rows in the Flexi-Talent engagement detail panel still showed Time Left and overdue metadata even though those assignments were no longer active. Root cause The engagement detail assignment renderer always displayed the time-left field whenever backend timing data existed and did not check the assignment status before treating the row as current work. What was changed Added a current-assignment status check for selected and assigned rows, and render the Time Left metadata only for those active statuses. Any added/updated tests Added an EngagementsView test covering completed, offer rejected, and terminated rows with overdue timing data to ensure their Time Left/overdue metadata is hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Completed, offer rejected, and terminated assignment rows in the Flexi-Talent engagement detail panel still showed Time Left and overdue metadata even though those assignments were no longer active.
Root cause
The engagement detail assignment renderer always displayed the time-left field whenever backend timing data existed and did not check the assignment status before treating the row as current work.
What was changed
Added a current-assignment status check for selected and assigned rows, and render the Time Left metadata only for those active statuses.
Any added/updated tests
Added an EngagementsView test covering completed, offer rejected, and terminated rows with overdue timing data to ensure their Time Left/overdue metadata is hidden.
Validation: