Conversation
What was broken Members whose submissions failed screening on completed Design challenges saw an empty Screening tab instead of their result and scorecard link. Root cause The completed-challenge visibility filter returned an empty row set for non-privileged viewers below the screening threshold before the ownership filter could retain the viewer's own submission. What was changed Allow below-threshold viewers to fall through to the existing ownership filter, preserving access to their own screening result while keeping other members' rows hidden. Any added/updated tests Added a TabContentScreening regression test covering a completed challenge with owned and foreign failed submissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Members whose submissions failed screening on completed Design challenges saw an empty Screening tab instead of their failed result, score, and scorecard link.
Root cause
The completed-challenge visibility filter returned an empty row set for non-privileged viewers below the screening threshold before the existing ownership filter could retain the viewer's own submission.
What was changed
Removed the premature empty result so below-threshold viewers fall through to the existing ownership and assignment filter. Failed submitters can now see their own screening result while other members' rows remain hidden. Existing scorecard authorization and link rendering continue to provide access to the member's own scorecard.
Any added/updated tests
Added a
TabContentScreeningregression test that supplies owned and foreign failed submissions for a completed challenge and verifies that only the owned row is displayed.Validation:
yarn test:no-watch --runInBand src/apps/review/src— 35 suites and 134 tests passed.yarn lint— passed.yarn run build— passed with existing repository warnings.origin/devrun reports the same 13 suites and 36 tests failing.