Conversation
What was broken Members could not narrow My Past Challenges to challenges where they served in a reviewer role. Root cause The page had no role control, and its request service and state did not carry resource-role filters to the review API. What was changed Added an All roles/Reviewer filter backed by the eight reviewer resource-role IDs identified for PM-5471. The selection is serialized to the API, retained across sorting and pagination, and removed by Clear. Any added/updated tests Added page and hook tests for the role options, all eight IDs, pagination persistence, and clearing. Updated the review service test for comma-separated query serialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Members could not narrow My Past Challenges to challenges where they served in a reviewer role.
Root cause
The page had no role control, and its request service and state did not carry resource-role filters to the review API.
What was changed
All roles/Reviewerfilter to My Past Challenges.Reviewerto the eight resource-role IDs identified in PM-5471.Any added/updated tests
yarn lint: passed.yarn run build: passed with existing warnings.yarn test:no-watch --runInBand: all PM-5471 tests passed; the repository retains the same 13 failing suites and 36 failing tests as cleanorigin/dev, all outside the review app.