Conversation
What was broken Project Managers could see projects with billing accounts, but searching for those accounts in the Projects filter returned no options. Root cause (if identifiable) The async filter returned only Billing Accounts API matches. Project Managers can see project-assigned accounts that are intentionally absent from their direct billing-account grants, and the loader ignored options already derived from visible projects. What was changed Merged case-insensitive matches from visible project billing accounts with remote search results, retaining local matches if remote search fails. Any added/updated tests Added a ProjectsFilter regression test confirming a Project Manager can find Platform Dev - One from a visible project when the API returns no matching accounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Project Managers could see projects with billing accounts, but searching for those accounts in the Projects filter returned no options.
Root cause (if identifiable)
The async filter returned only Billing Accounts API matches. Project Managers can see project-assigned accounts that are intentionally absent from their direct billing-account grants, and the loader ignored options already derived from visible projects.
What was changed
Merged case-insensitive matches from visible project billing accounts with remote search results. Local project matches remain available if the remote billing-account search fails.
Any added/updated tests
Added a ProjectsFilter regression test confirming a Project Manager can find Platform Dev - One from a visible project when the API returns no matching accounts.
Validation:
yarn lintpasses.yarn run buildpasses with existing repository warnings.yarn test:no-watchretains 13 failing suites and 36 failing tests that reproduce unchanged on untouchedorigin/dev; this branch adds one passing suite and one passing test.