Conversation
What was broken Virus-scan failures appeared as Pending in the AI-only Approval table even though the expanded reviewer details showed the Virus Scan as failed. Root cause Infected submissions do not continue to AI decision creation, and the Approval status renderer defaulted every submission without a decision to Pending. What was changed Failed file-submission virus scans now take precedence over AI decision status and render as Infected using the existing failed-status styling. Any added/updated tests Added a focused Approval table regression test covering an infected submission and preserving the normal Pending fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Virus-scan failures appeared as Pending in the AI-only Approval table even though the expanded reviewer details showed the Virus Scan as failed.
Root cause
Infected submissions do not continue to AI decision creation, and the Approval status renderer defaulted every submission without a decision to Pending.
What was changed
Failed file-submission virus scans now take precedence over AI decision status and render as Infected using the existing failed-status styling. URL-only submissions remain exempt from virus-scan failure handling.
Any added/updated tests
Added a focused Approval table regression test covering an infected submission and preserving the normal Pending fallback.
Validation completed:
yarn test:no-watch --runTestsByPath src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentAiApproval.spec.tsx— passed.yarn test:no-watch --testPathPattern=src/apps/review— passed (35 suites, 134 tests).yarn lint— passed.yarn run build— passed with existing warnings.The repository-wide
yarn test:no-watchwas also run. It retained 13 unrelated failing suites and 36 failing tests that were reproduced unchanged on a cleanorigin/devworktree; all 35 Review app suites passed.