Conversation
What was broken The edit-footer cancellation status menu extended beyond the left edge of the viewport, so QA could not see the complete menu. Root cause The previous follow-up reused the header-oriented cancellation action in the form's left footer slot. Its 280px menu remained right-aligned to the narrow trigger and expanded offscreen to the left. What was changed Added an optional start alignment for the cancellation menu and enabled it only for the edit-footer action. Header and read-only footer actions retain their existing end alignment, and the challenge editor documentation now describes the footer behavior. Any added/updated tests Extended ChallengeEditorPage coverage to verify that the edit-footer cancellation menu receives the start-alignment modifier while preserving the existing status selection, confirmation, PATCH, and refresh assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
QA confirmed that the cancellation workflow added by the previous PM-5757 follow-up now works, but the edit-footer status menu extends beyond the left edge of the viewport and is not fully visible.
Root cause
PR #2094 reused the header-oriented cancellation action in the form's left footer slot. The 280px menu remained right-aligned to the narrow Cancel trigger, so it expanded offscreen to the left.
What was changed
Added an optional start alignment for the cancellation status menu and enabled it only for the edit-footer action. The menu now expands rightward into the form and remains inside the viewport, while header and read-only footer instances retain their existing end alignment.
Updated the challenge editor documentation to describe the footer menu behavior.
Any added/updated tests
Extended
ChallengeEditorPage.spec.tsxto verify that the edit-footer cancellation menu receives the start-alignment modifier. The existing assertions continue to cover status selection, confirmation, the challenge PATCH payload, and refresh.Validation:
ChallengeEditorPagesuite: 30 tests passed.yarn lint: passed.yarn run build: passed with existing warnings.git diff --check: passed.origin/devworktree reproduced the identical 999 passing and 32 failing tests in the same 18 suites, confirming the failures are pre-existing.