Conversation
What was broken Work Manager did not expose the submission-limit setting for design challenges and normalized every existing value to Unlimited, preventing managers from configuring or preserving a limited count. Root cause The compatibility field had been changed to render no controls and always rewrite submissionLimit metadata to the unlimited payload. What was changed Restored the setting as mutually exclusive Unlimited and Limited radio options, with a numeric count field for Limited. The editor now safely restores existing limits, defaults missing or malformed metadata to Unlimited, and persists the established JSON metadata contract without disrupting initial resource hydration. Any added/updated tests Updated MaximumSubmissionsField tests to cover the default, existing limits, count changes, switching to Unlimited, malformed metadata, and deferred dirty-state normalization. Updated the challenge editor documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Work Manager did not expose the submission-limit setting for design challenges and normalized every existing value to Unlimited, preventing managers from configuring or preserving a limited count.
Root cause
The compatibility field had been changed to render no controls and always rewrite
submissionLimitmetadata to the unlimited payload.What was changed
Restored the setting as mutually exclusive Unlimited and Limited radio options, with a numeric count field for Limited. The editor now safely restores existing limits, defaults missing or malformed metadata to Unlimited, and persists the established JSON metadata contract without disrupting initial resource hydration.
Any added/updated tests
Updated
MaximumSubmissionsFieldtests to cover the default, existing limits, count changes, switching to Unlimited, malformed metadata, and deferred dirty-state normalization. Updated the challenge editor documentation.Validation completed successfully with 6 focused tests,
yarn lint, andyarn run build.