-
Notifications
You must be signed in to change notification settings - Fork 9
[v6 PROD RELEASE] - dev -> master #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… submissions that aren't owned by the current submitter
…ment-fields Update challenge reviewer payment fields
…on-submitter owned submissions, allowing us to better show data in the UI.
…pleted-notification PM-2222 - send notification when ai workflow run has compelted
…n review unless review phase is open
…ubmitters, for display in CA.
…e the MM for the system-admin app / challenge API
… issues with screeners / reviewers (PM-2506)
…t move to the finance API
…ge-has-ai-review PM-1904 - expose if challenge has AI review assigned
Bumps [axios](https://github.com/axios/axios) from 1.9.0 to 1.12.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.9.0...v1.12.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.12.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…n/axios-1.12.0 Bump axios from 1.9.0 to 1.12.0
chore(PM-2539): added timeout for prisma service
| # For pulling payment details (used by platform-ui) | ||
| FINANCE_DB_URL= | ||
| #Prisma timeout | ||
| REVIEW_SERVICE_PRISMA_TIMEOUT=10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[💡 style]
Consider adding a newline at the end of the file to adhere to POSIX standards. This can help avoid issues with some tools that expect a newline at the end of files.
| jobs: | ||
| trivy-scan: | ||
| name: Use Trivy | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[maintainability]
Consider using a stable version of the runner, such as ubuntu-latest, instead of a specific version like ubuntu-24.04. This can help avoid potential issues when the specified version becomes outdated or deprecated.
| output: "trivy-results.sarif" | ||
| severity: "CRITICAL,HIGH,UNKNOWN" | ||
| scanners: vuln,secret,misconfig,license | ||
| github-pat: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[❗❗ security]
Ensure that the GITHUB_TOKEN secret is correctly configured and has the necessary permissions for the actions being performed. This is crucial for the security and proper functioning of the workflow.
| phaseId String | ||
| basePayment Float? | ||
| incrementalPayment Float? | ||
| fixedAmount Float? @default(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[correctness]
The fixedAmount field now has a default value of 0. Ensure that this change aligns with the business logic, as it may affect calculations or logic that previously relied on null values to indicate unset or optional fields.
| phaseName String | ||
| basePayment Float? | ||
| incrementalPayment Float? | ||
| fixedAmount Float? @default(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[correctness]
The fixedAmount field now has a default value of 0. Ensure that this change aligns with the business logic, as it may affect calculations or logic that previously relied on null values to indicate unset or optional fields.
No description provided.