Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
6f1ef83
PM-2222 - send notification when ai workflow run has compelted
vas3a Oct 9, 2025
a6bbd91
add review link for ai run completed notification
vas3a Oct 10, 2025
c0a0e3a
typo fix & common config
vas3a Oct 12, 2025
b4cdbf6
use the correct db connection
vas3a Oct 13, 2025
3d9eb92
Better handling of "isLatest" for unlimited submission type challenges
jmgasper Oct 15, 2025
a84d585
Updated data for F2F iterative reviews for trimmed data for reviews /…
jmgasper Oct 15, 2025
0582798
Update challenge reviewer payment fields
vas3a Oct 15, 2025
2ad2cdd
Merge pull request #125 from topcoder-platform/challenge-reviewer-pay…
vas3a Oct 15, 2025
45fa146
Updates to return filtered information on reviews in a challenge to n…
jmgasper Oct 15, 2025
6ee41d2
Fix sending contact manager messages
jmgasper Oct 16, 2025
1682350
Handle returning screening review details at the appropriate time
jmgasper Oct 16, 2025
15210c2
Merge pull request #122 from topcoder-platform/PM-2222_send-airun-com…
vas3a Oct 16, 2025
bb35775
Fix copilot / admin reopening review scorecard, and don't allow reope…
jmgasper Oct 16, 2025
b520e44
Allow reviews to be pulled for challenge that failed review (PM-2361)
jmgasper Oct 17, 2025
8060c79
Better handling of post-mortem reviews that aren't tied to a submission
jmgasper Oct 17, 2025
c70c70a
Fixes for filtering by challenge status
jmgasper Oct 17, 2025
a639d46
Better handling of checkpoints and visibility after their related pha…
jmgasper Oct 17, 2025
2cff0e0
Approval phase handling updates
jmgasper Oct 18, 2025
54464e9
PM-1904 - expose if challenge has AI review assigned
vas3a Oct 20, 2025
d977c40
Allow marathon matches to return all reviewSummations to registered s…
jmgasper Oct 21, 2025
634a0cc
Further fixes for MMs
jmgasper Oct 21, 2025
2f702f1
Add submitter ID value to review summations to make it easier to clos…
jmgasper Oct 21, 2025
cdc2755
Clear out scores if a scorecard is reopened. Fixes up some permissio…
jmgasper Oct 22, 2025
172449f
Fix for MM review summation pulling to allow submitters to see each o…
jmgasper Oct 22, 2025
e0bc50a
Metadata for storing review details, and remove payments endpoint tha…
jmgasper Oct 22, 2025
032ed4e
Build fixes
jmgasper Oct 22, 2025
f77ae40
Better block for switching scorecards
jmgasper Oct 22, 2025
f9f1229
Allow F2F submitters to see other submissions once the challenge is c…
jmgasper Oct 23, 2025
f7b9f9a
Performance indices
jmgasper Oct 23, 2025
54fff64
PM-1904 - fix typo and optimize hasAiReview query
vas3a Oct 23, 2025
f56e2e7
Merge pull request #126 from topcoder-platform/PM-1904_append-challen…
vas3a Oct 23, 2025
bfc2fdb
Bump axios from 1.9.0 to 1.12.0
dependabot[bot] Oct 23, 2025
06ce94f
Prod migration updates and incremental migration
jmgasper Oct 23, 2025
15125ab
Fix dirty prod data
jmgasper Oct 23, 2025
580a97a
Build fix
jmgasper Oct 23, 2025
bf95ebf
Fix for dirty prod data
jmgasper Oct 23, 2025
3bc5d54
Fix up migrate to handle dirty data with logging and skipping
jmgasper Oct 24, 2025
e4ca78e
Show all reviews to reviewers once a challenge completes
jmgasper Oct 24, 2025
1dabf7c
Review detail visibility for reviewers
jmgasper Oct 24, 2025
9d445c8
adds Trivy action
kkartunov Oct 24, 2025
9292153
fix: added timeout for prisma
hentrymartin Oct 24, 2025
f8f667d
fix: added timeout for prisma
hentrymartin Oct 24, 2025
77db0d1
Additional visibility tweaks and fixes for proper phase handling
jmgasper Oct 26, 2025
405a0a1
Tweaks for data visibility at different stages
jmgasper Oct 27, 2025
bc1fa9f
add permissions to Trivy action
kkartunov Oct 27, 2025
0cac1ca
Merge pull request #127 from topcoder-platform/dependabot/npm_and_yar…
kkartunov Oct 27, 2025
4317c09
fix: extracted to a util method
hentrymartin Oct 27, 2025
e0bbc81
Allow approval visibility to submitters
jmgasper Oct 28, 2025
ef42e7e
Additional fixes for returning screenings if a user is a reviewer
jmgasper Oct 28, 2025
1b8bbfd
Tweaks for showing specific details to mixed roles
jmgasper Oct 28, 2025
afb492d
fix: lint
hentrymartin Oct 28, 2025
9c40d78
Merge pull request #128 from topcoder-platform/pm-2539
hentrymartin Oct 28, 2025
6167afb
Incremental update tweaks
jmgasper Oct 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ workflows:
- feat/ai-workflows
- pm-1955_2
- re-try-failed-jobs
- pm-2539


- 'build-prod':
Expand Down
2 changes: 2 additions & 0 deletions .env.sample
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,5 @@ SENDGRID_ACCEPT_REVIEW_APPLICATION="d-2de72880bd69499e9c16369398d34bb9"
SENDGRID_REJECT_REVIEW_APPLICATION="d-82ed74e778e84d8c9bc02eeda0f44b5e"
# For pulling payment details (used by platform-ui)
FINANCE_DB_URL=
#Prisma timeout
REVIEW_SERVICE_PRISMA_TIMEOUT=10000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 style]
Consider adding a newline at the end of the file to adhere to POSIX standards. This can help avoid issues with some tools that expect a newline at the end of files.

34 changes: 34 additions & 0 deletions .github/workflows/trivy.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Trivy Scanner

permissions:
contents: read
security-events: write
on:
push:
branches:
- main
- dev
pull_request:
jobs:
trivy-scan:
name: Use Trivy
runs-on: ubuntu-24.04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
Consider using a stable version of the runner, such as ubuntu-latest, instead of a specific version like ubuntu-24.04. This can help avoid potential issues when the specified version becomes outdated or deprecated.

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Run Trivy scanner in repo mode
uses: aquasecurity/trivy-action@0.33.1
with:
scan-type: "fs"
ignore-unfixed: true
format: "sarif"
output: "trivy-results.sarif"
severity: "CRITICAL,HIGH,UNKNOWN"
scanners: vuln,secret,misconfig,license
github-pat: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
Ensure that the GITHUB_TOKEN secret is correctly configured and has the necessary permissions for the actions being performed. This is crucial for the security and proper functioning of the workflow.


- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: "trivy-results.sarif"
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"test:cov": "jest --coverage",
"test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
"test:e2e": "jest --config ./test/jest-e2e.json",
"db:migrate": "ts-node prisma/migrate.ts",
"postinstall": "pnpm exec prisma generate && pnpm exec prisma generate --schema=prisma/challenge-schema.prisma && pnpm exec prisma generate --schema=prisma/resource-schema.prisma && pnpm exec prisma generate --schema=prisma/member-schema.prisma"
},
"dependencies": {
Expand All @@ -34,7 +35,7 @@
"@prisma/client": "^6.3.1",
"@types/jsonwebtoken": "^9.0.9",
"archiver": "^6.0.2",
"axios": "^1.9.0",
"axios": "^1.12.0",
"class-transformer": "^0.5.1",
"class-validator": "^0.14.1",
"cors": "^2.8.5",
Expand Down Expand Up @@ -81,7 +82,7 @@
"winston": "^3.17.0"
},
"prisma": {
"seed": "ts-node prisma/migrate.ts",
"seed": "pnpm run db:migrate",
"seed222": "ts-node prisma/seed.ts"
},
"jest": {
Expand All @@ -104,4 +105,4 @@
"coverageDirectory": "../coverage",
"testEnvironment": "node"
}
}
}
45 changes: 24 additions & 21 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions prisma/challenge-schema.prisma
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,9 @@ model ChallengeReviewer {
isMemberReview Boolean
memberReviewerCount Int?
phaseId String
basePayment Float?
incrementalPayment Float?
fixedAmount Float? @default(0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The fixedAmount field now has a default value of 0. Ensure that this change aligns with the business logic, as it may affect calculations or logic that previously relied on null values to indicate unset or optional fields.

baseCoefficient Float?
incrementalCoefficient Float?
type ReviewOpportunityTypeEnum?
aiWorkflowId String? @db.VarChar(14)

Expand Down Expand Up @@ -622,8 +623,9 @@ model DefaultChallengeReviewer {
isMemberReview Boolean
memberReviewerCount Int?
phaseName String
basePayment Float?
incrementalPayment Float?
fixedAmount Float? @default(0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The fixedAmount field now has a default value of 0. Ensure that this change aligns with the business logic, as it may affect calculations or logic that previously relied on null values to indicate unset or optional fields.

baseCoefficient Float?
incrementalCoefficient Float?
opportunityType ReviewOpportunityTypeEnum?
isAIReviewer Boolean

Expand Down
Loading