fix: raise session-start's PR limit above gh's own default, and restore the truncation caveat - #242
Merged
Merged
Conversation
…re the truncation caveat The shipped gather ran `gh pr list … --limit 20`. That is BELOW the default it was presumably meant to control: `gh pr list --help` on gh 2.96.0 reads `-L, --limit int Maximum number of items to fetch (default 30)`. So the explicit flag made the sweep narrower than passing nothing at all. Two separable losses, and the second survives any choice of number. The limit is now 100, and the caveat the ancestor carried is back: `gh pr list` reports nothing when it truncates, so a full page must be treated as truncated and re-run higher. This list is the entire input to the Now bucket's PR items, so a PR past the cutoff is not under-reported — it is invisible, while the ones above it render as though they were all of them. The "What it reads" row now points at the gather for that rather than naming a bare command. THE SURVEY HALF OF #237, which is the part that made this more than a one-line edit. Each of the four shared workflow docs was compared against the cs-toolkit adapter it was generalized out of, looking for operational detail lost in the extraction. Result: this was the only one. - session-start — the other gap was an entire step, already shipped as #238. - parallel — the Stale-premise pre-flight survived generalization intact (kit parallel.md:89), as did the lane-contract preamble, which moved to parallel-headless.md rather than being dropped. - pr-watch — the kit is AHEAD of its ancestor: it gained the draft-bit flags section, a fuller `--mark-seen` contract, and the gh-less REST fallback in Notes. - wrap-up — every ancestor step has a counterpart except `docs/user/dashboard-snapshot.md`, which is project-specific and correctly absent. One correction to that survey rather than a finding: a probe for `gh pr ready` returned zero hits in the kit's wrap-up and looked like a drop. It is not — the kit says "mark the PR ready … and run the watch-and-fix loop (`pr-watch`)" (wrap-up.md:141), generalized because `vcs.forge` is configurable. The probe was too literal, and reporting its zero as a finding would have been the failure this repo keeps logging: a check that never reached its subject. VERIFIED: `gh pr list --help` on gh 2.96.0 for the default-30 claim, quoted above rather than recalled; `make test` 721 passed; `python scripts/kit_doctor.py` 32 unchanged, 0 differ, 0 missing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe session-start workflow now queries up to 100 open pull requests, detects potentially truncated results, and explains the effect on 🔴 prioritization. The manifest records the updated workflow hash. ChangesSession-start PR gathering
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #237.
The bug
The shipped gather ran:
That is below the default it was presumably meant to control:
So the explicit flag made the sweep narrower than passing nothing at all.
The fix, in two separable parts
The number is now 100, matching the ancestor this workflow was generalized out
of.
The caveat matters more, because it survives any choice of number:
gh pr listreports nothing when it truncates, so a full page has to be treated as truncated
and re-run higher. That sentence existed in the ancestor and was lost in the
extraction.
Why it is not cosmetic: this list is the entire input to the 🔴 bucket's PR
items. A PR past the cutoff is not under-reported, it is invisible — and the ones
above it render as though they were all of them, which is a briefing that is
confidently wrong rather than visibly incomplete.
The
What it readsrow now points at the gather instead of naming a baregh pr list.The survey half — the part that made this more than a one-line edit
#237asked for the four shared workflow docs to be diffed against the cs-toolkitadapters they were generalized out of, "even if the result is 'nothing else'".
Done. This was the only substantive drop.
session-start#238parallelparallel.md:89); the lane-contract preamble moved toparallel-headless.mdrather than being droppedpr-watch--mark-seencontract, and the gh-less REST fallback in Noteswrap-updocs/user/dashboard-snapshot.md, which is project-specific and correctly absentOne correction to that survey, recorded rather than buried
A probe for
gh pr readyreturned zero hits in the kit'swrap-upand lookedlike a second drop. It is not one. The kit says "mark the PR ready … and run the
watch-and-fix loop (
pr-watch)" atwrap-up.md:141— generalized deliberately,because
vcs.forgeis configurable and a literalghcommand would be wrong for aGitLab adopter.
The probe was too literal. Reporting its zero as a finding would have been exactly
the failure this repo keeps logging — a check that never reached its subject,
returning the answer that looked like a result.
Verification
gh pr listdefaults to 30gh pr list --helpon gh 2.96.0, quoted above rather than recalledmake test→ 721 passedpython scripts/kit_doctor.py→ 32 unchanged, 0 differ, 0 missingWhat this does not establish: as with
#238, this is prose an agent executesand no test in this repo runs it. The
make testgreen means the regeneratedmanifest is consistent and nothing else broke — it says nothing about whether the
guidance is right.
Summary by CodeRabbit