topolvm.io#592
Merged
llamerada-jp merged 1 commit intomainfrom Nov 16, 2022
Merged
Conversation
bells17
commented
Nov 10, 2022
| ## About the legacy flag | ||
|
|
||
| In https://github.com/topolvm/topolvm/pull/539, the domain name which is used for CRD and other purposes was changed from topolvm.cybozu.com to topolvm.io. | ||
| In https://github.com/topolvm/topolvm/pull/592, the domain name which is used for CRD and other purposes was changed from topolvm.cybozu.com to topolvm.io. |
Closed
nbalacha
previously approved these changes
Nov 11, 2022
peng225
reviewed
Nov 11, 2022
Contributor
|
What I usually do when I need to change something in a commit is the following: This will overwrite the branch head so I can use the same PR. It may be a way to proceed with these changes instead of creating a new PR. |
Contributor
Author
Thank you. I never tried the |
Contributor
llamerada-jp
left a comment
There was a problem hiding this comment.
This PR looks good. Would you please squash this PR after other reviewers approve?
Contributor
|
LGTM. I will approve it after you squashed it. |
llamerada-jp
approved these changes
Nov 16, 2022
peng225
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a merge PR for reducing the number of commits for #539
The below commands created this PR: