driver/node: recreate device if owner or device mode is unexpected#680
Merged
driver/node: recreate device if owner or device mode is unexpected#680
Conversation
Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
The `devicePermission` variable contains not only the file permission bits but the file type bits. It should be rather called as `deviceMode`. Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
When topolvm-node received a NodePublishVolume CSI request, it creates a device file. It reuse the file if the file already exists and its mode satisfies some conditions. However, it ignores many parts of the permission bits and, more over, the owner of the file. This PR changes to require that the owner and the file type match with expectation in order to reuse the device file. Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
peng225
approved these changes
Mar 23, 2023
pluser
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When topolvm-node received a NodePublishVolume CSI request, it creates a device file. It reuse the file if the file already exists and its mode satisfies some conditions. However, it ignores many parts of the permission bits and, more over, the owner of the file.
This PR changes to require that the owner and the file type match with expectation in order to reuse the device file.