removed RedirectAgent overwrite#256
Closed
virgil wants to merge 1 commit intotor2web:masterfrom
virgil:patch-9
Closed
removed RedirectAgent overwrite#256virgil wants to merge 1 commit intotor2web:masterfrom virgil:patch-9
virgil wants to merge 1 commit intotor2web:masterfrom
virgil:patch-9
Conversation
As far as I can tell we don't need this overwrite. The TBB allows funny redirects, and TBB has higher security expectations than tor2web. Ergo I argue in favor of removing this code.
Contributor
|
virgil sorry to correct you but this is a lot needed; this was needed in relation to this ticket #162 and is really important to keep this. why are you thinking to remove it? is there a particular use case in which it does disturb you? |
Contributor
Author
|
Oh that makes sense. Keep it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell we don't need this overwrite. The TBB allows funny redirects, and TBB has higher security expectations than tor2web. Ergo I argue in favor of removing this code.