Supplementary pull request for argmax/argmin as second argument on max/min calls in torch7 - #575
Closed
mevGDM wants to merge 2 commits into
Closed
Supplementary pull request for argmax/argmin as second argument on max/min calls in torch7#575mevGDM wants to merge 2 commits into
mevGDM wants to merge 2 commits into
Conversation
…st for argmax/argmin as second argument on max/min calls
Member
|
fixed via b2af7ea |
Member
|
@soumith Can you revert the change? See torch/torch7#523 |
Member
|
sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a minor change to MultiLabelMarginCriterion.c to adhere to the new interface for minall/maxall functions which are changed in the pull request for argmax/argmin as second argument on max/min calls. This will not build until the torch/torch7#489 pull is finished.