fix: @granite-js/lottie LottieView props - #239
Merged
Merged
Conversation
jingjing2222
requested review from
gronxb,
heecheolman,
intmain,
l2hyunwoo,
leegeunhyeok and
raon0211
as code owners
March 24, 2026 06:24
🦋 Changeset detectedLatest commit: 2644139 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jingjing2222
marked this pull request as draft
March 24, 2026 06:25
jingjing2222
marked this pull request as ready for review
March 25, 2026 15:21
heecheolman
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
durationin@granite-js/lottieso it affects playback as intended.Previously,
durationwas exposed in the public API but was not actually used when building native props. As a result, settingdurationdid not change the animation playback length and onlyspeedwas applied.Changes
durationinLottieViewdurationwhen the source is a JS animation objectResult
durationnow behaves consistently with the documented APIspeedbehavior is preserved whendurationis not provideddurationVerification
yarn workspace @granite-js/lottie typecheckyarn workspace @granite-js/lottie lint