Skip to content

fix: consistent sort order in sortPlugin#25

Merged
ho991217 merged 1 commit into
toss:implement-v1from
jaem0629:fix/sort-plugin-consistency
Jan 21, 2026
Merged

fix: consistent sort order in sortPlugin#25
ho991217 merged 1 commit into
toss:implement-v1from
jaem0629:fix/sort-plugin-consistency

Conversation

@jaem0629

@jaem0629 jaem0629 commented Jan 21, 2026

Copy link
Copy Markdown

checkOrder used original key order, but fixOrder sorted them alphabetically.

For { "name": "test", "zebra": "z", "apple": "a" }:

  • check: ["name", "zebra", "apple"] → pass
  • fix: ["name", "apple", "zebra"] → different

Moved sortedRestKeys outside if block so both use the same sorted order.

@jaem0629 jaem0629 requested a review from ho991217 as a code owner January 21, 2026 07:34

@ho991217 ho991217 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ho991217 ho991217 merged commit b3fd9b6 into toss:implement-v1 Jan 21, 2026
1 check failed
@jaem0629 jaem0629 deleted the fix/sort-plugin-consistency branch January 21, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants