fix(getSafeAreaInset): re-export the SafeAreaInset type from the package root - #456
Merged
Conversation
🦋 Changeset detectedLatest commit: f3593fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: 0 B Total Size: 97.3 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 1664 1664
Branches 500 500
=========================================
Hits 1664 1664 🚀 New features to boost your workflow:
|
mnxmnz
force-pushed
the
453-root-safe-area-inset-type
branch
from
August 31, 2026 05:09
4794963 to
f3593fa
Compare
mnxmnz
marked this pull request as ready for review
August 31, 2026 05:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #453.
@react-simplikit/mobileexportedtype SafeAreaInset. The absorption in #437 moved every other export of that package to the root barrel but left this one behind, so it is the only symbol of the old package with no root equivalent —import type { SafeAreaInset } from '@react-simplikit/mobile'has nothing to migrate to.One line in
src/index.ts. The leaf barrelsrc/mobile/utils/getSafeAreaInset/index.ts:1already exported the type, so nothing below the root needed touching.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?