Remove Clone derivations from SetMultipleResponseHeader* types - #714
Merged
Conversation
This allows downstream consumers to not be impacted by unneccesary Clone bounds. Fixes: tower-rs#713
1 task
jplatte
approved these changes
Jul 15, 2026
jplatte
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This allows downstream consumers to not be impacted by uneccesary Clone bounds.
Includes a regression test that simplifies the reproduction case, fails to compile without the fix, and succeeds with it.
Solution
Apply the same fix as #703 to Response types as well, using the more narrow and accurate Clone definition vs the derived Clone one.
Fixes: #713