🐛 fix(driver): remove scheduler-dependent registry race - #616
Merged
gaborbernat merged 1 commit intoJul 29, 2026
Merged
Conversation
A download producer is unique and cannot become stale through the public registry API, so conditional removal defended an impossible state. The test widened a finish window with a watch borrow and polled the scheduler, which made line execution nondeterministic. Remove the unreachable identity check and exercise replacement through the public lifecycle.
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download-registry replacement check depended on an OS thread winning a scheduling race before the main thread entered a
yield_nowloop. When removal won immediately, the loop body never ran; the check also modeled a stale active producer that the public API cannot create.DownloadProduceris unique,registercannot replace an occupied entry, and finishing consumes the producer. Removal can therefore be unconditional. The replacement contract now follows public registry operations in order: finish the old transfer, observe its terminal state, register the replacement, and confirm that it remains current.