Skip to content

🐛 fix(dom): lock threaded tree reads#617

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/threaded-tree-access
Jul 8, 2026
Merged

🐛 fix(dom): lock threaded tree reads#617
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/threaded-tree-access

Conversation

@gaborbernat

Copy link
Copy Markdown
Member

Free-threaded readers crashed while one thread walked child, sibling, or attribute arrays and another rewired the same tree.

The fix takes the existing tree lock around lazy node-axis cursor movement, sequence snapshots, and attrs view materialization.

@gaborbernat gaborbernat added the bug Something isn't working label Jul 8, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 91 untouched benchmarks
⏩ 18 skipped benchmarks1


Comparing gaborbernat:fix/threaded-tree-access (4e86478) with main (83cc16c)

Open in CodSpeed

Footnotes

  1. 18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gaborbernat gaborbernat merged commit da688c5 into tox-dev:main Jul 8, 2026
49 checks passed
@gaborbernat gaborbernat deleted the fix/threaded-tree-access branch July 10, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant