🐛 fix(dom, xslt): lock subtree copies#635
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Free-threaded copies read mutable source trees without holding their critical sections. Lock source and destination handles together during adoption, and lock standalone DOM and stylesheet copies at the source.
94db8bd to
ab4801b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
th_tree_copy_noderead mutable source nodes without holding their tree handles. Concurrent attribute writes could pair a copied pointer with a length from another source state; the 3.14t reproducer returned oneLwhere onlysor 4,096Lcharacters were valid.Acquire source and destination handles with the ordered two-object critical section during adoption. Standalone DOM copies and stylesheet merges lock their source handles, while XSLT execution locks both the source and stylesheet. The copy remains a single arena pass; GIL builds preprocess the new handle expressions away.