Skip to content

🧪 test(serialize): widen the node differential timeout - #705

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/node-differential-timeout
Aug 3, 2026
Merged

🧪 test(serialize): widen the node differential timeout#705
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/node-differential-timeout

Conversation

@gaborbernat

Copy link
Copy Markdown
Member

The Windows 3.10 cell of #704 went red on test_folding_preserves_behavior[literals]. That case is the first in tests/serialize/js/test_fold.py to launch node, and subprocess.run raised TimeoutExpired at its 60s bound. The job's slowest-durations table puts the next case at 14.92s for its two launches and nothing else in the file above a second, which points at a one-time cost to start a cold node.exe. Which case pays that cost depends on collection order, so the failure moves around.

The bound exists to stop a snippet that never returns from wedging the run, so it goes to 300s, past a slow process start and still short enough to catch a hang. tests/serialize/js/test_mangle.py runs the same helper against the mangling differential and carried the same 60s bound, so both move together.

The tests/conformance suites that shell out to node keep their 120s bounds. That job runs only on ubuntu-24.04, where this cold-start cost has not shown up.

The Windows 3.10 cell of PR tox-dev#704 failed on
test_folding_preserves_behavior[literals], the first case in the file to
launch node, when subprocess.run hit its 60s bound. The next case spent
14.92s across its two launches and the rest of the file stayed under a
second each, which points at a one-time cost to start a cold node.exe.
Collection order picks which case pays it, so the failure moves around.

The bound is there to stop a snippet that never returns from wedging the
run, so 300s clears a slow process start and still catches a hang. The
mangling differential runs the same helper and carried the same bound.
@codspeed-hq

codspeed-hq Bot commented Aug 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 107 untouched benchmarks
⏩ 29 skipped benchmarks1


Comparing gaborbernat:fix/node-differential-timeout (8093538) with main (401a2dc)

Open in CodSpeed

Footnotes

  1. 29 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gaborbernat
gaborbernat enabled auto-merge (squash) August 3, 2026 19:32
@gaborbernat
gaborbernat merged commit 966701c into tox-dev:main Aug 3, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant