🧪 test(serialize): widen the node differential timeout - #705
Merged
gaborbernat merged 1 commit intoAug 3, 2026
Conversation
The Windows 3.10 cell of PR tox-dev#704 failed on test_folding_preserves_behavior[literals], the first case in the file to launch node, when subprocess.run hit its 60s bound. The next case spent 14.92s across its two launches and the rest of the file stayed under a second each, which points at a one-time cost to start a cold node.exe. Collection order picks which case pays it, so the failure moves around. The bound is there to stop a snippet that never returns from wedging the run, so 300s clears a slow process start and still catches a hang. The mangling differential runs the same helper and carried the same bound.
Merging this PR will not alter performance
Comparing Footnotes
|
gaborbernat
enabled auto-merge (squash)
August 3, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows 3.10 cell of #704 went red on
test_folding_preserves_behavior[literals]. That case is the first intests/serialize/js/test_fold.pyto launchnode, andsubprocess.runraisedTimeoutExpiredat its 60s bound. The job's slowest-durations table puts the next case at 14.92s for its two launches and nothing else in the file above a second, which points at a one-time cost to start a coldnode.exe. Which case pays that cost depends on collection order, so the failure moves around.The bound exists to stop a snippet that never returns from wedging the run, so it goes to 300s, past a slow process start and still short enough to catch a hang.
tests/serialize/js/test_mangle.pyruns the same helper against the mangling differential and carried the same 60s bound, so both move together.The
tests/conformancesuites that shell out tonodekeep their 120s bounds. That job runs only onubuntu-24.04, where this cold-start cost has not shown up.