🐛 fix(parser): close scoped nobr - #725
Open
gaborbernat wants to merge 1 commit into
Open
Conversation
gaborbernat
added
bug
Merging this PR will improve performance by 5.22%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_feature[transform-dense] |
41.5 ms | 39.4 ms | +5.22% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gaborbernat:fix/718-nobr-adoption (79a419b) with fix/issue-710-xml-find (0243780)
Footnotes
-
29 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
A table with an open marquee can leave the active nobr formatting entry outside scope. The adoption agency then returns without closing that entry, causing the next nobr start tag to nest. Apply the specified any-other-end-tag fallback when adoption cannot act. The focused WPT case and reduced controls pin sibling placement.
gaborbernat
force-pushed
the
fix/718-nobr-adoption
branch
from
August 9, 2026 16:43
5eb6271 to
79a419b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adoption-agency path can leave an active
nobrentry outside scope after table recovery with an openmarquee. A laternobrstart tag then nests inside the first element, while the WPT case cited in #718 requires two body siblings.This patch applies the any-other-end-tag fallback when the adoption agency cannot act on the formatting element. The fallback follows the WHATWG active-formatting rules and leaves the existing adoption path unchanged when it succeeds.
Closes #718.