🐛 fix(clean): decode CSS safety tokens - #730
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
gaborbernat
force-pushed
the
fix/708-sanitizer-rewrites
branch
from
August 9, 2026 16:43
c38f63d to
3fa4e29
Compare
gaborbernat
force-pushed
the
fix/721-css-escapes
branch
from
August 9, 2026 16:43
cfab290 to
738b345
Compare
gaborbernat
force-pushed
the
fix/708-sanitizer-rewrites
branch
from
August 9, 2026 18:51
3fa4e29 to
3cd9ed0
Compare
gaborbernat
force-pushed
the
fix/721-css-escapes
branch
from
August 9, 2026 18:52
738b345 to
10c2e38
Compare
gaborbernat
force-pushed
the
fix/708-sanitizer-rewrites
branch
from
August 9, 2026 18:55
3cd9ed0 to
5fb7614
Compare
gaborbernat
force-pushed
the
fix/721-css-escapes
branch
3 times, most recently
from
August 9, 2026 23:51
1ebe20b to
1bbc392
Compare
gaborbernat
force-pushed
the
fix/708-sanitizer-rewrites
branch
from
August 10, 2026 00:15
f16b49a to
a602cb3
Compare
gaborbernat
force-pushed
the
fix/721-css-escapes
branch
2 times, most recently
from
August 10, 2026 00:18
68bac63 to
f4c7b57
Compare
gaborbernat
marked this pull request as draft
August 10, 2026 00:19
gaborbernat
force-pushed
the
fix/721-css-escapes
branch
from
August 10, 2026 06:51
f4c7b57 to
5095776
Compare
Base automatically changed from
fix/708-sanitizer-rewrites
to
fix/738-match-cast
August 10, 2026 13:10
gaborbernat
marked this pull request as ready for review
August 10, 2026 13:11
gaborbernat
force-pushed
the
fix/721-css-escapes
branch
4 times, most recently
from
August 10, 2026 17:14
b076775 to
7eb54b1
Compare
CSS escape obfuscation bypassed the sanitizer baseline because checks compared raw characters. The scanner also rejected function-like text inside inert strings and comments. Decode CSS identifiers and URL values in native code. Reject malformed URL tokens and legacy executable properties, and grow scheme buffers without truncation. Refs #721
gaborbernat
force-pushed
the
fix/721-css-escapes
branch
from
August 10, 2026 18:42
35d0c62 to
15dcafc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS escapes let active syntax survive raw-character sanitizer checks. Those checks also rejected function-like text inside inert strings and comments. 🔒
The native CSS scanner decodes escaped identifiers and URL values before comparison. It rejects malformed URL tokens and the legacy executable properties
behaviorand-moz-binding, respects token boundaries, and grows scheme buffers without truncation.This branch follows #728 because rewritten style values need its final safety pass. The decoded checks close #721.