Skip to content

Move io traits impl for ip types to toxcore #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

Move io traits impl for ip types to toxcore #19

merged 1 commit into from
Feb 19, 2018

Conversation

@kurnevsky
Copy link
Member

@kurnevsky kurnevsky commented Feb 17, 2018

No description provided.

@coveralls
Copy link

coveralls commented Feb 17, 2018

Pull Request Test Coverage Report for Build 205

  • 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 96.722%
Files with Coverage Reduction New Missed Lines %
src/toxcore/dht.rs 1 98.73%
src/toxcore/state_format/old.rs 1 98.46%
src/toxcore_tests/dht_tests.rs 1 99.38%
Totals Coverage Status
Change from base Build 195: -0.03%
Covered Lines: 6256
Relevant Lines: 6468
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 224

  • 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 96.753%
Files with Coverage Reduction New Missed Lines %
src/toxcore/dht_new/kbucket.rs 1 98.54%
Totals Coverage Status
Change from base Build 222: 0.0%
Covered Lines: 6258
Relevant Lines: 6468
💛 - Coveralls

@kurnevsky kurnevsky changed the title refactor(dht): move io traits impl for ip types to toxcore Move io traits impl for ip types to toxcore Feb 18, 2018
kpp
kpp requested changes Feb 18, 2018
View reviewed changes
Copy link
Member

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix doc

src/toxcore/binary_io_new.rs Outdated
// Ip Type
// Value | Type
// ----- | ----
// `2` | UDP IPv4
Copy link
Member

@kpp kpp Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? IpAddr Does not contain the type.

Copy link
Member Author

@kurnevsky kurnevsky Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, removed this comment - it was present in original code.

@kurnevsky kurnevsky force-pushed the move_ip_addr_io_impl branch from 9761ea0 to bb519dc Compare February 18, 2018 18:41
@kpp kpp force-pushed the move_ip_addr_io_impl branch from bb519dc to 0473e23 Compare February 19, 2018 07:50
@kpp kpp merged commit 8ddd77d into master Feb 19, 2018
@kpp kpp deleted the move_ip_addr_io_impl branch February 19, 2018 08:21
kurnevsky pushed a commit that referenced this pull request Sep 4, 2022
Merge pull request #19 from tox-rs/syslog
68114cb 
Write logs to syslog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpp kpp kpp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kurnevsky @coveralls @kpp