refactor dht_node #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 53
💛 - Coveralls |
kpp
reviewed
Feb 3, 2018
src/toxcore/dht_new/dht_impl.rs
Outdated
| [`.kind()`](./struct.DhtPacket.html#method.kind) method. | ||
| Returns `None` in case of faliure: | ||
| Returns `Error` in case of faliure: |
kurnevsky
reviewed
Feb 8, 2018
| format!("DhtPacket decrypt error: {:?}", e)) | ||
| }); | ||
|
|
||
| match self.packet_kind { |
Member
There was a problem hiding this comment.
I propose switch to DhtPacketPayload::from_bytes when #11 is merged - it will reduce code size.
Member
|
This PR is closed in favor of #25 |
kurnevsky
pushed a commit
that referenced
this pull request
Sep 4, 2022
Save DHT keys to a binary file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor dht_node.rs.
Revise codes according to changes of packet.rs
Introduce PrecomputedKey HashMap
Move Option to Result if available