-
Notifications
You must be signed in to change notification settings - Fork 16
Composable scalar transforms #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
488c780
Took a stab at this idea. Needs testing
Ickaser efbb5e4
The crucial step: composite!
Ickaser 09bb188
don't nest composite transforms if possible
Ickaser 8e0d88e
Properly refer to composite operator
Ickaser ab6e1ff
Rename elemental scalar transformations
Ickaser d5d244a
Export newly renamed transforms
Ickaser b1d9bdc
Rename and export Logistic
Ickaser d5e0e13
Make indexing directly on CompositeScalarTransform pass through to un…
Ickaser 92479ea
get indexing right
Ickaser 30b327e
Make types inferrable for transform_and_logjac
Ickaser f333507
Logistic, not logit
Ickaser 677579d
Add inverses
Ickaser 17b69fe
Add consistency tests parallel to the existing ones
Ickaser f813763
Add a TVNeg transformation for negative
Ickaser 1c0d71b
Add test to make sure scalar transformations at least compose
Ickaser 3e492db
More composing in test
Ickaser 45aabf6
Test consistency for a bunch of arbitrary compositions
Ickaser a133017
Add inverse_and_logjac for new types, consistent transform_and_logjac…
Ickaser 54b601b
Commit to new style, mark a few tests as broken for now
Ickaser d87fa2a
Provide some default show methods
Ickaser 683d924
Add some documentation for composable scalar transforms
Ickaser f5d9740
Widen types allowed by scalar inverses to Number, and TVScale to anyt…
Ickaser 04f3a33
Try adding Unitful tests: commented out because not working yet
Ickaser 4107271
Some docs explaining Unitful transform
Ickaser 3c7b1a5
Add tests to cover more constructions of composition
Ickaser 07ef76f
Don't test Jacobian for transforms that add units
Ickaser 74da494
Remove log-Jacobian functionality for Unitful-type transforms
Ickaser 6dff1f9
Fix ill-formed test
Ickaser d106ef7
Improve test coverage
Ickaser e3747e3
Improve pretty printing for common transforms to keep printing behavi…
Ickaser 14bba55
Add a non-unicode alias for composition operator
Ickaser 5ff6832
More alias tests in scalar show
Ickaser 67f1eb4
Fix log-Jacobian of inverse of Exp transform; move inverse_and_logjac…
Ickaser 12137f9
important typo in docs
Ickaser e5bb567
make compose a direct constructor for CompositeScalarTransform, rathe…
Ickaser 4e7a085
Make sure only ScalarTransforms get passed to CompositeScalarTransform
Ickaser dbeb48a
Move Unitful-related tests to be closer together
Ickaser a5ff605
Remove unnecessary test
Ickaser 9b2938f
Add some internal docs
Ickaser 5b1f055
Get inverse_and_logjac tested for Identity()
Ickaser 6cf09c1
make test look nicer
Ickaser 2dd2bb4
Remove argcheck on inverse(Exp)
Ickaser ad49fd0
Remove argcheck on inverse(Logistic)
Ickaser 05754ac
Cleaner typing
Ickaser e7c231e
Better zeros for inverse_and_logjac
Ickaser 0604ddd
more logjac_zero
Ickaser 593c2f8
Clean up foldl/foldr operation
Ickaser 6ebb9ab
Remove indexing into CompositeTransform
Ickaser f467e63
Merge branch 'composite-scalar' of https://github.com/Ickaser/Transfo…
Ickaser de68e4d
Restrict cases where asR+, etc. get string printed
Ickaser 0af7406
Clearly better suggestions
Ickaser 0935932
Use CompositionsBase to provide non-Unicode compose
Ickaser d7d2398
Nice little elision
Ickaser bf0142d
Merge branch 'composite-scalar' of https://github.com/Ickaser/Transfo…
Ickaser a214583
Get scalar show tests passing again, for now
Ickaser 7996d6f
Actually import compose, redo test
Ickaser f65fe05
Remove ShiftedExp,etc. from new tests
Ickaser 4172d02
Amend asR+ an asI to be individual scalar transforms, not single-elem…
Ickaser 13034d4
Fully remove ShiftedExp and ScaledShiftedLogistic
Ickaser 090b08f
Add another note to docs about extending scaling for custom number types
Ickaser f0e3d90
Update docs to clarify use of non-Real numbers
Ickaser 7daeb1e
Trim a whitespace
Ickaser 9018fb0
Catch CompositeScalarTransforms inside the Vararg composite method
Ickaser 8d168fe
Merge branch 'composite-scalar' of https://github.com/Ickaser/Transfo…
Ickaser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.