Skip to content

Conversation

@Ickaser
Copy link
Contributor

@Ickaser Ickaser commented Nov 26, 2025

This may not be strictly necessary, but I have found it convenient to be able to merge multiple NamedTuple transformations by merging the underlying NamedTuples. Previously I did this by relying on the internal fields, but that approach broke (which is totally reasonable, it was an implementation detail).

Should this be a documented feature, in addition to tested?

Copy link
Collaborator

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it would be good to ensure it's inferred.

@tpapp
Copy link
Owner

tpapp commented Nov 27, 2025

Yes, please mention it in the docs, eg in this sectio.

Ickaser and others added 4 commits November 29, 2025 20:44
Co-authored-by: David Müller-Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Müller-Widmann <devmotion@users.noreply.github.com>
@Ickaser
Copy link
Contributor Author

Ickaser commented Nov 30, 2025

I've added a little note to the docs which suggests the way I am using this; if it should be broadened or not have the link to ConstructionBase.setproperties I am open to suggestions.

@tpapp
Copy link
Owner

tpapp commented Dec 1, 2025

The note in the docs is fine, the documentation is probably due a rewrite one of these days so I will mention this.

@Ickaser
Copy link
Contributor Author

Ickaser commented Dec 4, 2025

Is there anything else this needs before being merge-able (haha)?

@tpapp
Copy link
Owner

tpapp commented Dec 4, 2025

Yes, can you please add a trivial test set with collisions (overlapping names)? It is fine to rely on merge, but it something changes I want to be in the position to catch that.

After that, I will merge immediately, I think you address the concerns of @devmotion. Thanks for all the great work!

@Ickaser
Copy link
Contributor Author

Ickaser commented Dec 4, 2025

I've added a test for name collisions (and reworded the docs to demonstrate the same thing). Thanks!

@tpapp tpapp merged commit 465ab99 into tpapp:master Dec 5, 2025
5 checks passed
tpapp referenced this pull request Dec 5, 2025
@Ickaser Ickaser deleted the merge-tuples branch December 5, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants