Skip to content

cli: misc niceties#174

Merged
jmcph4 merged 5 commits into
mainfrom
cli-niceties
Jun 25, 2026
Merged

cli: misc niceties#174
jmcph4 merged 5 commits into
mainfrom
cli-niceties

Conversation

@jmcph4

@jmcph4 jmcph4 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Ticket

UX improvements for tplus CLI

Changes

  • Assume transport for --orderbook-base-url
  • Provide meaningful error message for bad auth when decrypting a stored account

@jmcph4 jmcph4 self-assigned this Jun 23, 2026
@jmcph4
jmcph4 marked this pull request as draft June 23, 2026 00:27
@jmcph4
jmcph4 marked this pull request as ready for review June 23, 2026 01:39
@jmcph4
jmcph4 requested a review from antazoey June 23, 2026 01:39
pw = _resolve_password(password, f"Enter password for '{name}': ")
return decrypt_keyfile(pw, f"{path}")
try:
return decrypt_keyfile(pw, f"{path}")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(can be separate PR) but wondering if we should have retries here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in re-prompt the user for a correct password?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya

@jmcph4
jmcph4 merged commit 7d82cfb into main Jun 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants