Conversation
ras0q
reviewed
May 4, 2023
Comment on lines
20
to
26
| type Context struct { | ||
| context.Context | ||
| // P BOTが受信したMESSAGE_CREATEDイベントの生のペイロード | ||
| P *MessageCreatedPayload | ||
| P *payload.MessageCreated | ||
| // Args 投稿メッセージを空白区切りで分けたもの | ||
| Args []string | ||
| } |
There was a problem hiding this comment.
各メソッドの第1引数にcontext入れる方がよく見る気がするんですが構造体の中に入れてるのってなんか意図あったりしますか？
Member
Author
There was a problem hiding this comment.
正直ここでは大した意味はないです embedとして入れてcontext.Contextの拡張として独自のContextを定義しようと思っただけですね
ですが現状ではcontext.Contextの拡張としてはあんまり役割を果たしてないです 今後timeoutとか使いたくなったときに入れることができるくらいです
Context以外の構造体にcontext.Contextを入れて連れ回すのはアンチパターンなのはそうですね
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.