-
Notifications
You must be signed in to change notification settings - Fork 1
V3 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
V3 #35
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
41111b2
use ws bot
motoki317 76443d1
restructure config
motoki317 e572a39
add deploy cmd
motoki317 9261548
use prefix for commands
motoki317 50fecba
add prefix to usage help
motoki317 506396a
refactor help message build
motoki317 10ef353
refactor server config structure
motoki317 6bc0680
rm service cmd
motoki317 d89dda0
use spf13/viper
motoki317 d09d37a
allow customizing commands file dir
motoki317 43afa2a
add runtime cmds
motoki317 6692af8
Merge branch 'master' into v3
motoki317 c175fcc
Merge branch 'master' into v3
motoki317 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| *.iml | ||
| /.idea/ | ||
| ./DevOpsBot | ||
| ./log | ||
| ./config.yaml | ||
| ./dist | ||
|
|
||
| /DevOpsBot | ||
| /log | ||
| /config.yaml | ||
| /dist | ||
| /test.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
各メソッドの第1引数にcontext入れる方がよく見る気がするんですが構造体の中に入れてるのってなんか意図あったりしますか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
正直ここでは大した意味はないです embedとして入れてcontext.Contextの拡張として独自のContextを定義しようと思っただけですね
ですが現状ではcontext.Contextの拡張としてはあんまり役割を果たしてないです 今後timeoutとか使いたくなったときに入れることができるくらいです
Context以外の構造体にcontext.Contextを入れて連れ回すのはアンチパターンなのはそうですね